generate: order service After=systemd-sysusers.service#573
Open
guilherme-puida wants to merge 1 commit intocanonical:mainfrom
Open
generate: order service After=systemd-sysusers.service#573guilherme-puida wants to merge 1 commit intocanonical:mainfrom
guilherme-puida wants to merge 1 commit intocanonical:mainfrom
Conversation
netplan-configure.service needs to resolve the "systemd-network" GID. To do that, is ordered After=nss-user-lookup.target. However, if this target is After= another service that is itself After=network-online.target (for example, winbind.service), this causes an ordering cycle. Mar 23 18:02:51 netplan-winbind systemd[1]: network.target: Found ordering cycle: winbind.service/stop after nss-user-lookup.target/stop after netplan-configure.service/stop after network-pre.target/stop after network.target/stop - after winbind.service Mar 23 18:02:51 netplan-winbind systemd[1]: network.target: Job winbind.service/stop deleted to break ordering cycle starting with network.target/stop Since "systemd-network" is created early by systemd-sysusers, we can order the service After=systemd-sysusers.service to ensure that the group already exists without triggering network-related cycles.
benhoyt
added
the
needs review soon
Author
|
FYI: This was uploaded to Ubuntu as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
netplan-configure.service needs to resolve the "systemd-network" GID. To do that, is ordered After=nss-user-lookup.target. However, if this target is After= another service that is itself
After=network-online.target (for example, winbind.service), this causes an ordering cycle.
Since "systemd-network" is created early by systemd-sysusers, we can order the service After=systemd-sysusers.service to ensure that the group already exists without triggering network-related cycles.
Related: https://code.launchpad.net/~puida/ubuntu/+source/netplan.io/+git/netplan.io/+merge/502503 and https://bugs.launchpad.net/ubuntu/+source/netplan.io/+bug/2071747 (comment #5 onwards)
Checklist
make checksuccessfully.make check-coverage).